Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger name to slack notification #90

Closed
bouk opened this issue Dec 17, 2020 · 5 comments · May be fixed by #91
Closed

Add trigger name to slack notification #90

bouk opened this issue Dec 17, 2020 · 5 comments · May be fixed by #91

Comments

@bouk
Copy link

bouk commented Dec 17, 2020

Thanks for this project, it's super useful. I'd love it if you added the name of the trigger to the slack notification, which would make it easier to see what a notification is for

@LOZORD
Copy link
Contributor

LOZORD commented Dec 18, 2020

You're welcome 😄 I totally agree - for silly reasons we don't include the trigger name in the Pub/Sub payload (or Build resource for that matter). Until we provide the trigger name in the payload or provide it as an available substitution, the best alternative is to stick a GCB gRPC (or JSON) client in the notifier and call GetBuildTrigger, which should include the trigger name.

Please feel free to send a PR for this functionality as others would definitely benefit!

@bouk
Copy link
Author

bouk commented Dec 18, 2020

PR submitted #91

@jrissler
Copy link

+1 this is really useful project. This feature would be ultra useful - otherwise given you have multiple apps being triggered doesn't appear to be a way to distinguish them.

@LOZORD
Copy link
Contributor

LOZORD commented Feb 12, 2021

Hi all! We on Cloud Build are aware of this need but want to have a standardized implementation for all notifiers, so I filed #95. We're currently waiting on our PM to share a doc in this repo for this set of features. I can't give a timeline, but I was told Soon ™️ . The implementation will be open to the community to code up.

@vicpadilla
Copy link
Member

You can use {{.Build.Substitutions.TRIGGER_NAME}} in the template to get the trigger name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants