Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isaac_ros_nitros_image_type/src/nitros_image.cpp #7

Closed
GeorgeNegret opened this issue Oct 25, 2022 · 3 comments
Closed

isaac_ros_nitros_image_type/src/nitros_image.cpp #7

GeorgeNegret opened this issue Oct 25, 2022 · 3 comments
Assignees
Labels
bug Something isn't working coming soon! Targeted for next release

Comments

@GeorgeNegret
Copy link

I think line 30 from nitros_image.cpp
#include "sensor_msgs/sensor_msgs/image_encodings.hpp"
should be changed to :
#include "sensor_msgs/image_encodings.hpp"

@hemalshahNV
Copy link
Contributor

Good catch. When building ROS2 from source, however, the header files for sensor_msgs end up in /opt/ros/humble/install/include/sensor_msgs/sensor_msgs/image_encodings.hpp. We haven't investigated why that happens yet but it leads to the awkward include there.

@nakai-omer
Copy link

@hemalshahNV I think this should be re-opened, as this causes this repo to fail building for anyone not building ROS2 from source

@hemalshahNV
Copy link
Contributor

That's fair. With some symlinks this could be worked around for a binary install of ROS2 Humble. Isaac ROS only supports Ubuntu 20.04 at the moment (as of DP2.1) on both x86_64 and Jetson which is a Tier 3 platform for ROS2 Humble (source compatibility only, no binaries). We will need to figure this out as part of Jammy support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coming soon! Targeted for next release
Projects
None yet
Development

No branches or pull requests

4 participants