validate-codeowners

This CI/CD component provides a job to validate your GitLab project's CODEOWNERS file. It also includes a Linux binary and Docker image, which you can run from your desktop or from your own CI/CD job.

It performs the following validation checks:

• CODEOWNERS file resides in one of the three supported locations.
• Syntax is valid.
• All owners are valid GitLab @groups, @users, or user@emails.
• All @groups are direct members of the project.
• All @users are direct members of the project.
• All user@emails are direct members of the project.

About direct memberships

What's all the fuss about checking direct memberships? While you can add CODEOWNERS entries for both direct and inherited members of a project, CODEOWNERS entries for inherited members are only optional, not required. Moreover, when reading a CODEOWNERS file, it is not obvious which entries will be optional vs. required - one would need to manually cross-check each CODEOWNERS entry against the project's direct memberships. Since the point of having a CODEOWNERS file is almost always to enforce MR approvals of specific files/directories, this job makes sure that all CODEOWNERS entries are for direct members, and are therefore required approvals.

From the GitLab documentation:

For approval to be required, groups as Code Owners must have a direct membership (not inherited membership) in the project. Approval can only be optional for groups that inherit membership. Members in the Code Owners group also must be direct members, and not inherit membership from any parent groups.

Example CI/CD Component Usage

.gitlab-ci.yml

include:
  - component: gitlab.com/tedspinks/validate-codeowners/[email protected]
    inputs:
      GITLAB_TOKEN: ${GITLAB_TOKEN}

validate-codeowners:
  extends: .validate-codeowners
  stage: test
  # Example rule will only run this job in MRs, when the CODEOWNERS file has changed
  rules:
    - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
      changes:
        - CODEOWNERS
        - docs/CODEOWNERS
        - .gitlab/CODEOWNERS

Example CLI Usage

sudo curl -L -o /usr/local/bin/validate-codeowners \
 https://gitlab.com/tedspinks/validate-codeowners/-/releases/1.0.0/downloads/linux-amd64/validate-codeowners

sudo chmod +x /usr/local/bin/validate-codeowners

export GITLAB_TOKEN=glpat-blahblah12345
export CI_PROJECT_PATH=my-group/my-project-with-codeowners-file
export CI_COMMIT_REF_NAME=my-branch
export CI_API_GRAPHQL_URL=https://gitlab.com/api/graphql
export CI_API_V4_URL=https://gitlab.com/api/v4

cd my-git-clone-directory

validate-codeowners

Inputs

CI/CD Component Inputs

• GITLAB_TOKEN - Required. GitLab token with "read_api" scope. This is usually an Admin token. See token permission details. Summary of required permissions:
  1. Owner of the target project.
  2. Member of ALL groups that might be listed as Codeowners (or that might contain users listed as Codeowners).
  3. To validate emails: group owners for enterprise users, or admin for self-hosted.
• GITLAB_TIMEOUT_SECS - Optional. Timeout in seconds for communication with the GitLab APIs. Default is "30".

Pipeline Variables

• CODEOWNERS_DEBUG - Optional. Set to "true" for debug logging (it's VERY verbose). Handy for manual pipeline runs in the web UI.

GitLab Predefined variables

• CI_PROJECT_PATH - The namespace/project path of your project with the CODEOWNERS file you want to validate.
• CI_COMMIT_REF_NAME - The branch or tag name of your project.
• CI_API_GRAPHQL_URL - The GitLab API GraphQL root URL. For SaaS GitLab this will be https://gitlab.com/api/graphql.
• CI_API_V4_URL - The GitLab REST API v4 root URL. For SaaS GitLab this will be https://gitlab.com/api/v4.

Design Considerations

The GitLab GraphQL API includes a very nice CODEOWNERS syntax validator. I believe this is the same validator that runs when you edit a CODEWONERS file from the GitLab web UI. Rather than reinvent the wheel and write a complete parser, I decided to take advantage of this API function. And, with syntax validation taken care of, I was able to write a much simpler splitCodeownersLine() function, which just grabs the file patterns and owners from each line.

To do the actual validations, I tried to use GitLab's newer GraphQL API as mush as possible. However, it wasn't apparent to me how to get a project's shared_with_groups field from the GraphQL queries, so I ended up using the REST projects/ endpoint for that piece.