Bug 1612289 - Remove IDBTransaction.commit from webidl, since its implementation is only a stub. r=#dom-workers-and-storage
ClosedPublic
Actions

Authored by • sg on Jan 30 2020, 1:24 PM.

Details

Reviewers

emilio
asuth

Group Reviewers

Restricted Project

Bugzilla Bug ID

1612289

Summary

Disable tests for IDBTransaction.commit to avoid intermittent timeouts.

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central
Branch: default

Unit TestsFailed
View All

Time

Test

32,358 ms

code-review::mercurial

WARNING: The code review bot failed to apply your patch.

unable to find 'testing/web-platform/meta/IndexedDB/idb-explicit-commit.any.js.ini' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file testing/web-platform/meta/IndexedDB/idb-explicit-commit.any.js.ini.rej
abort: patch failed to apply

Event Timeline

• sg created this revision.Jan 30 2020, 1:24 PM

Herald added a project: secure-revision. · View Herald TranscriptJan 30 2020, 1:24 PM

Harbormaster completed remote builds in B157312: Diff 223410.Jan 30 2020, 1:24 PM

phab-bot requested review of this revision.Jan 30 2020, 1:25 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

• sg updated this revision to Diff 223428.Jan 30 2020, 1:45 PM

Harbormaster completed remote builds in B157326: Diff 223428.Jan 30 2020, 1:45 PM

So here's my understanding of this for the other webidl folks as @asuth explained to me in person: The first patch implementing this API was just a stub, and that got to beta, but the actual implementation didn't. It should've probably landed behind a pref or such, but uplifting this to beta to correct that mistake looks good.

The API is implemented and passing tests on nightly.

This revision is now accepted and ready to land.Jan 30 2020, 5:05 PM

asuth accepted this revision.Jan 30 2020, 5:06 PM

Landed in beta only.