Skip to content

[master] fix ignored interface name matches method#8629

Merged
AlbumenJ merged 6 commits intoapache:masterfrom
zrlw:issue-8581
Sep 8, 2021
Merged

[master] fix ignored interface name matches method#8629
AlbumenJ merged 6 commits intoapache:masterfrom
zrlw:issue-8581

Conversation

@zrlw
Copy link
Contributor

@zrlw zrlw commented Aug 28, 2021

What is the purpose of the change

fix #8581

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (fd80172) to head (ab783e2).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #8629      +/-   ##
============================================
+ Coverage     61.04%   61.07%   +0.03%     
- Complexity      448      449       +1     
============================================
  Files          1097     1097              
  Lines         44407    44415       +8     
  Branches       6470     6472       +2     
============================================
+ Hits          27109    27128      +19     
+ Misses        14313    14301      -12     
- Partials       2985     2986       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrlw zrlw changed the title set literal pattern string for ignored given interface name tests fix #8581 Aug 28, 2021
Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zrlw
Copy link
Contributor Author

zrlw commented Aug 29, 2021

@wangchengming666 pls review again

@zrlw zrlw changed the title fix #8581 [master] fix ignored interface name matches method Sep 5, 2021
@AlbumenJ
Copy link
Member

AlbumenJ commented Sep 8, 2021

Please check if it is necessary to patch to 3.0 branch.

@AlbumenJ AlbumenJ merged commit 485aac1 into apache:master Sep 8, 2021
@zrlw
Copy link
Contributor Author

zrlw commented Sep 8, 2021

Please check if it is necessary to patch to 3.0 branch.

#8723

@zrlw zrlw deleted the issue-8581 branch February 17, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants