Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all hardcoded links to 18f.gsa.gov pages #3860

Open
2 tasks
Tracked by #3864
beechnut opened this issue Jun 6, 2024 · 3 comments
Open
2 tasks
Tracked by #3864

Change all hardcoded links to 18f.gsa.gov pages #3860

beechnut opened this issue Jun 6, 2024 · 3 comments

Comments

@beechnut
Copy link
Contributor

beechnut commented Jun 6, 2024

If you search the content folder for //18f.gsa.gov/, there are about 750 results.

At some point, we should change all of these links to the 11ty style of linking: {{ the path | url }}

Problem: In the absence of analytics, don't know if any of these links are broken, or how many, because we only check internal links, because checking external links is hard.

Benefit: If we change the linking from hardcoded to {{ }}, all of these links become internal links. (Right now, they're considered external when you're working locally, on localhost.) If these links become internal, they become check-able, improving the integrity of the site.

It's debatable whether this is in or out of scope for the migration, but since it's a non-trivial content change that doesn't block migration, I'm going to set it as out-of-scope for now.

Tasks

@bpdesigns
Copy link
Member

bpdesigns commented Jun 7, 2024

straightforward and useful task

@beechnut
Copy link
Contributor Author

beechnut commented Jul 9, 2024

@bpdesigns This is a post-migration task. This shouldn't be prioritized until after #3839 is complete.

@bpdesigns
Copy link
Member

Thanks @beechnut I'll add this to blocked/waiting for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants