TextBoxMask Binding

[ZingPow]

How does the binding work with the TextBoxMask? If I create the following XAML

<TextBox controls1:TextBoxMask.Mask="99" InputScope="Number" Text="{Binding PrizeExpiryTime, Mode=TwoWay}" Margin="2,0,0,0" />

It seems that it doesn't pick up the binding from the value in the ViewModel, but if I enter a value in the textbox then it gets passed through which is great, but if I leave and go back to that page the field is blank again, so I'm just wondering how the binding is supposed to work.

[skendrot]

Ping @IbraheemOsama
Looks like it's not accounting for the Text property being set upon creation.

[skendrot]

Note: Test cases:

Text matches mask:

    <TextBox controls:TextBoxMask.Mask="99" Text="10"/>

Text does not match mask:

    <TextBox controls:TextBoxMask.Mask="99" Text="ab"/>

Text is longer than mask:

    <TextBox controls:TextBoxMask.Mask="99" Text="12345"/>`
    <TextBox controls:TextBoxMask.Mask="99" Text="abcd"/>

Text is shorter than mask:

    <TextBox controls:TextBoxMask.Mask="99" Text="4"/>`
    <TextBox controls:TextBoxMask.Mask="99" Text="a"/>

Any of these could happen with binding values

[ZingPow]

During my test, the value initially was 2 and didn't show up, then I entered in 99 which the binding did pass through, but when I came back to that screen (settings screen), the value displayed was __ so it really seems like the binding is working as just one way, view to view model and not both ways.

I came across another issue during my testing and I'll post it as a separate item.

[skendrot]

Updated test cases with text that is shorter than mask

[IbraheemOsama]

@ZingPow thanks for reporting, working on it to fix it :)
@skendrot thanks for the test cases really helpful.

[ZingPow]

Thank you for working on it. Blake From: Ibraheem Osama [mailto:notifications@github.com] Sent: Friday, December 23, 2016 6:20 PM To: Microsoft/UWPCommunityToolkit <UWPCommunityToolkit@noreply.github.com> Cc: ZingPow <mcneillb@zingpow.ca>; Mention <mention@noreply.github.com> Subject: Re: [Microsoft/UWPCommunityToolkit] TextBoxMask Binding (#737) @ZingPow <https://github.com/ZingPow> thanks for reporting, working on it to fix it :) @skendrot <https://github.com/skendrot> thanks for the test cases really helpful. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#737 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AJdAieKDZjx7Ai7cpiEMNIIU0ZjMeykjks5rLHNOgaJpZM4LRO4c> .

[ZingPow]

Issue #737 appears to work but I had raised an issue #740 ( #740 ) which was merged into 737 but it isn’t fixed (maybe it is not meant to be fixed??). The issue is where you have a mask with say two digits and you only enter 1 digit, for example I’m using this so the user can enter number of minutes for a timer, so they can enter anything from 0 to 99 minutes, but if they enter a single digit in the right position (ie “_2”) then the number isn’t received, as it has to be entered as “2_” to work. Is this an issue and if so should I open one on GitHub? Thanks Blake From: Ibraheem Osama [mailto:notifications@github.com] Sent: Friday, December 23, 2016 6:20 PM To: Microsoft/UWPCommunityToolkit <UWPCommunityToolkit@noreply.github.com> Cc: ZingPow <mcneillb@zingpow.ca>; Mention <mention@noreply.github.com> Subject: Re: [Microsoft/UWPCommunityToolkit] TextBoxMask Binding (#737) @ZingPow <https://github.com/ZingPow> thanks for reporting, working on it to fix it :) @skendrot <https://github.com/skendrot> thanks for the test cases really helpful. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#737 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AJdAieKDZjx7Ai7cpiEMNIIU0ZjMeykjks5rLHNOgaJpZM4LRO4c> .