Fix toast progress bar #1044
Merged
Fix toast progress bar #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XML should be <progress> rather than <progressBar>, and Status is a required property. Validated on latest Insider build that creating a progress bar notification works with these new changes
Contributor
Author
|
FYI, the code sample for creating a toast progress bar will be here: https://github.com/WindowsNotifications/quickstart-toast-progress-bar It currently uses raw XML since I wrote the sample before the NuGet package with progress bar was available. I was working on updating the sample to use the NuGet package today when I realized the NuGet package was generating the wrong XML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toast progress bar -> XML code had a few mistakes due to us adding this element early before things were finalized for the Creators Update :)
I've made these changes to the code and the tests, and also validated that you can successfully send a progress bar toast on the latest Insider build using the Notifications DLL with these changes.