[BladeView] proper scroll for Data binding; fixing #801 #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xied75, |
Contributor
Contributor
Author
|
@deltakosh Looks like everybody is pretty busy, may I take the courage to suggest merge this? For two lines of code it won't trigger the Big Red Button if something goes wrong. :) -- that is my naïve thinking, at least I should spot the bug first, or my app user... |
deltakosh
reviewed
Mar 28, 2017
| } | ||
| } | ||
| } | ||
| else if (e.CollectionChange == CollectionChange.ItemInserted) |
Contributor
There was a problem hiding this comment.
why not also on deleted?
Contributor
Author
|
When I try removing an item, it handled itself correctly. I thought adding code should be as small effect as possible. |
Contributor
|
ok so it makes sense I wanted to be sure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the supposed proper fix, but I've tried in my app and it works fine.
Without the
UpdateLayout();it only works randomly, I guess it takes time for the UI to refresh before we can scroll?