Fix menu alignment #1264
Merged
Fix menu alignment #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
nmetulev
approved these changes
Jun 29, 2017
Member
|
The fix doesn't work well with navigation on menu through keyboard. |
Contributor
Author
|
All my keyboard tests show it working fine. What case was not working? |
Contributor
Author
|
Latest fix should correct the keyboard cycle behavior |
IbraheemOsama
approved these changes
Jun 30, 2017
|
Does this account for a menu that is would be cut off so it would be right aligned? Typically in this would affect the last few menu items. |
Contributor
|
It doesn't seem like it would. @IbraheemOsama, @skendrot, could this be fixed?
|
Member
|
Will include the fix on the hover PR :) Thanks |
Contributor
|
I did a bit of exploring and I came up with this: #1284 Seems to work on my machines (CU+), but haven't test it on other devices/earlier builds. I'm ok with holding this of for next release where we can test it out a bit more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the menu directly below the button and align the left edges
Fixes #1258 and #1259