reverting back hamburgermenuitem #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermitdave
approved these changes
Jul 14, 2017
skendrot
suggested changes
Jul 14, 2017
| <!-- Items --> | ||
| <controls:HamburgerMenu.ItemsSource> | ||
| <controls:HamburgerMenuItemCollection> | ||
| <controls:HamburgerMenuImageItem Thumbnail="ms-appx:///Assets/Photos/BigFourSummerHeat.jpg" |
Contributor
There was a problem hiding this comment.
Let's keep these as ImageItems. Never made sense why they were glyph items
| PaneBackground="{Binding PaneBackground.Value}"> | ||
| <!-- Items --> | ||
| <controls:HamburgerMenu.ItemsSource> | ||
| <controls:HamburgerMenuItemCollection> |
Contributor
There was a problem hiding this comment.
Same comment from the bind file
|
|
||
| </Page.Resources> | ||
| <controls:HamburgerMenu x:Name="HamburgerMenu" | ||
| OpenPaneLength="240" |
Contributor
There was a problem hiding this comment.
Remove this. Pane length is set to default 320 now
skendrot
suggested changes
Jul 14, 2017
| <ColumnDefinition Width="48" /> | ||
| <ColumnDefinition /> | ||
| </Grid.ColumnDefinitions> | ||
| <FontIcon Grid.Column="0" |
Contributor
There was a problem hiding this comment.
Margin should be set to 16,12
Contributor
Author
There was a problem hiding this comment.
The Margin clips the font icon, doesn't scale it
Contributor
There was a problem hiding this comment.
This is the margin used by the navigation view
Contributor
There was a problem hiding this comment.
as long as the fontsize is 16 is should be fine
| <ColumnDefinition Width="48" /> | ||
| <ColumnDefinition /> | ||
| </Grid.ColumnDefinitions> | ||
| <Image Margin="12" |
| <ColumnDefinition Width="48" /> | ||
| <ColumnDefinition /> | ||
| </Grid.ColumnDefinitions> | ||
| <Image Source="{Binding Thumbnail}" Stretch="UniformToFill" Margin="12,12,11,12" /> |
| <ColumnDefinition /> | ||
| </Grid.ColumnDefinitions> | ||
| <FontIcon Grid.Column="0" | ||
| FontFamily="Segoe MDL2 Assets" |
skendrot
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.