TextBoxMask cursor at beginning if empty #757
Conversation
| displayText = displayText.Replace(key, placeHolder); | ||
| } | ||
|
|
||
| // if the textbox got focus and the textbox is emply (contains only mask) set the textbox cursor at the beginning to simulate normal TextBox behavior if it is empty. |
There was a problem hiding this comment.
Typo: "emply" instead of "empty"
…TextboxCursorBeginnging
|
|
||
| private static void Textbox_GotFocus(object sender, RoutedEventArgs e) | ||
| { | ||
| var textbox = sender as TextBox; |
There was a problem hiding this comment.
I'd suggest doing a single if (textbox == null) return; after this instead of all these null checks on every reference to textbox.
Having said that, this is a private method only used with the TextBox.GotFocus event, so the sender should always be set with the current instance of the TextBox control!
There was a problem hiding this comment.
Agreed. Do explicit cast and remove ?
There was a problem hiding this comment.
actually I need to ask @deltakosh is there is any chance I can get a null here from the framework ?
|
|
||
| private static void Textbox_GotFocus(object sender, RoutedEventArgs e) | ||
| { | ||
| var textbox = sender as TextBox; |
There was a problem hiding this comment.
Agreed. Do explicit cast and remove ?
| } | ||
|
|
||
| // if the textbox got focus and the textbox is empty (contains only mask) set the textbox cursor at the beginning to simulate normal TextBox behavior if it is empty. | ||
| if (string.Equals(textbox.Text, displayText)) |
There was a problem hiding this comment.
Should probably just always put the cursor to the end of where the user has entered text. If they have entered no text, it's at 0. If they have entered 3 of 10 characters (eg: phone number) then it's at 3.
There was a problem hiding this comment.
Actually, for the phone number example it would be at 4 to bypass the first dash
referencing issue #756