OneDrive for Business bug fixes, updated docs. Cleaned up Sample app … #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrolamas
suggested changes
Feb 3, 2017
| } | ||
|
|
||
| Shell.Current.DisplayWaitRing = true; | ||
| bool succeeded = true; |
Member
There was a problem hiding this comment.
Why not assume false as start value and only change to true in the end of the process? Seems to make more sense and simpler to implement (would only require a single place to change the value)
| } | ||
| catch (Exception ex) | ||
| { | ||
| Debug.WriteLine(ex.Message); |
Member
There was a problem hiding this comment.
Swallowing the exception and just debugging it seems a bit wrong, maybe adding a MessageDialog here also?
pedrolamas
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some onedrive service fixes, updated docs, tidied up sample app for onedrive service.