Update to CompositionSurfaceFactory 0.7.1 and fix SurfaceFactory usag… #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was submitted as discussed with @deltakosh.
The dependency on CompositionSurfaceFactory is updated to 0.7.1 from the prerelease version. Additionally, TileControl was fixed to properly consume SurfaceFactory.
The issue is that the SurfaceFactory object needs to be alive in order to regenerate surfaces it creates. Otherwise there is no one to observe when the graphics device is lost, which would leave all Composition surfaces empty. Also, because the SurfaceFactory was shared, it shouldn't be disposed by anyone other than the application author, or consumers of the toolkit might find their surfaces suddenly parent-less and empty in the event of losing the graphics device.