Skip to content

Conversation

@robmikh
Copy link
Contributor

@robmikh robmikh commented Feb 9, 2017

This was submitted as discussed with @deltakosh.

The dependency on CompositionSurfaceFactory is updated to 0.7.1 from the prerelease version. Additionally, TileControl was fixed to properly consume SurfaceFactory.

The issue is that the SurfaceFactory object needs to be alive in order to regenerate surfaces it creates. Otherwise there is no one to observe when the graphics device is lost, which would leave all Composition surfaces empty. Also, because the SurfaceFactory was shared, it shouldn't be disposed by anyone other than the application author, or consumers of the toolkit might find their surfaces suddenly parent-less and empty in the event of losing the graphics device.

@dnfclas
Copy link

dnfclas commented Feb 9, 2017

Hi @robmikh, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Feb 9, 2017

@robmikh, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@deltakosh deltakosh merged commit 633f2fd into CommunityToolkit:dev Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants