Check if item exists in the in-memory storage #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible solution for #910
| return item as StorageFile; | ||
| } | ||
|
|
||
| /// <summary> |
Contributor
There was a problem hiding this comment.
I would add that if one doesn't exist, we will return the default instance of this type.
deltakosh
approved these changes
Feb 10, 2017
Member
|
LGTM but I've another note not related to the PR, should we mention that any function access _inMemoryFileStorage to be not thread safe ? |
Contributor
Author
|
@IbraheemOsama I'm going to replace all dictionaries with concurrent ones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a way to request item from in-memory cache.
Possible solution for #910