ImageEx: DecodePixelHeight, DecodePixelType and DecodePixelWidth properties #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to ImageEx Modify CacheBase GetItemAsync to pass list of KeyValuePair objects to pass to generic type instantiation
Contributor
Author
|
Addresses issue #888 |
deltakosh
reviewed
Feb 13, 2017
| /// <param name="initializerKeyValues">key value pairs used when initializing instance of generic type</param> | ||
| /// <returns>awaitable task</returns> | ||
| protected override async Task<BitmapImage> InitializeTypeAsync(StorageFile baseFile) | ||
| protected override async Task<BitmapImage> InitializeTypeAsync(StorageFile baseFile, List<KeyValuePair<string, object>> initializerKeyValues) |
Contributor
There was a problem hiding this comment.
should be set to null by default to avoid breaking changes
deltakosh
reviewed
Feb 13, 2017
| /// <param name="initializerKeyValues">key value pairs used when initializing instance of generic type</param> | ||
| /// <returns>awaitable task</returns> | ||
| protected override async Task<BitmapImage> InitializeTypeAsync(IRandomAccessStream stream) | ||
| protected override async Task<BitmapImage> InitializeTypeAsync(IRandomAccessStream stream, List<KeyValuePair<string, object>> initializerKeyValues) |
Contributor
There was a problem hiding this comment.
should be set to null by default to avoid breaking changes
deltakosh
reviewed
Feb 13, 2017
| /// <param name="initializerKeyValues">key value pairs used when initializing instance of generic type</param> | ||
| /// <returns>awaitable task</returns> | ||
| protected abstract Task<T> InitializeTypeAsync(IRandomAccessStream stream); | ||
| protected abstract Task<T> InitializeTypeAsync(IRandomAccessStream stream, List<KeyValuePair<string, object>> initializerKeyValues); |
Contributor
There was a problem hiding this comment.
should be set to null by default to avoid breaking changes (true for all protected methods ;))
deltakosh
approved these changes
Feb 13, 2017
Contributor
deltakosh
left a comment
There was a problem hiding this comment.
Just a few changes but overall LGTM
shenchauhan
requested changes
Feb 13, 2017
Contributor
shenchauhan
left a comment
There was a problem hiding this comment.
A couple of quick changes
| var img = await ImageCache.Instance.GetFromCacheAsync(_uri, true, _tokenSource.Token); | ||
| var propValues = new List<KeyValuePair<string, object>>(); | ||
|
|
||
| if (DecodePixelHeight != 0) |
Contributor
There was a problem hiding this comment.
again sorry, should have said > 0
| propValues.Add(new KeyValuePair<string, object>(nameof(DecodePixelHeight), DecodePixelHeight)); | ||
| } | ||
|
|
||
| if (DecodePixelWidth != 0) |
Contributor
There was a problem hiding this comment.
sorry should have said >0
shenchauhan
approved these changes
Feb 13, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DecodePixelHeight, DecodePixelType and DecodePixelWidth properties to ImageEx
Modify CacheBase GetItemAsync to pass list of KeyValuePair objects to pass to generic type instantiation