Fix missing Register DOI button if configuration enabled

[amgciadev]

Fix for missing Register DOI button under Edit Item > Status tab

References

Add references/links to any related issues or PRs. These may include:

• Fixes Register DOI button is no longer available in Edit item > Status despite configuration enabled #2765

Description

Fix initialOperations variable typo and return ops array with register-doi op successfully added is the register doi configuration is enabled

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR fixes an issue ticket, I've linked them together.

[kshepherd]

Hi @amgciadev , thanks for this fix and my apologies for the delay in reviewing it.

I have tested and it works well overall, though I noted that the default/false behaviour on the handling of the 'button enabled' config property meant that instead of hiding the button as intended, it displays but disables the button.
I made a small change and pushed it to your PR branch to quickly sort that out.

1. If enabled or commented out inidentifiers.cfg, the button shows (and whether or not the button itself is 'enabled' depends on whether a DOI exists, filtering, etc)
2. If disabled or commented out in identifiers.cfg, the button does not show

I hope you agree with this small tweak - I will hold off merging for now. I'm confident but it would be great to get your +1.

I also opened a related PR DSpace/DSpace#9309 to update identifiers.cfg now that the enabled property can safely be commented out.

[amgciadev]

@kshepherd thanks for reviewing! Yes of course, no problem with your addition at all +1

[tdonohue]

👍 Thanks @amgciadev ! This looks good to me to. Gave it a light test to verify it works with the small backend PR from @kshepherd: DSpace/DSpace#9309 . They both work well.

[dspace-bot]

Successfully created backport PR for dspace-7_x:

• [Port dspace-7_x] Fix missing Register DOI button if configuration enabled #2802