File pagination simple and full item pages

[Raf-atmire]

References

Add references/links to any related issues or PRs. These may include:

• Fixes Files on item pages don't use pagination #759

Description

This PR will ensure that the Pagination for files attached to an Item on the simple and full item pages will be fixed and working. The page size is currently set to 5 as a default.

Instructions for Reviewers

List of changes in this PR:

• The file section on the simple item page will now have pagination.
• The file section on the full item page will now have pagination as well.
• Tests have been included for both cases

These changes can be reviewed by visiting an item with more than 5 Bitstreams. You'll now be able to access its Bitstreams on the simple item page through pagination with the 'view more' and 'collapse' buttons. It'll also be possible to view the pagination on the full item page through a complete pagination component including page numbers, size and total results.

Checklist

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes TSLint validation using yarn run lint
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs for any bug fixes, improvements or new features. A few reminders about what constitutes good tests:
  • Include tests for different user types (if behavior differs), including: (1) Anonymous user, (2) Logged in user (non-admin), and (3) Administrator.
  • Include tests for error scenarios, e.g. when errors/warnings should appear (or buttons should be disabled).
  • For bug fixes, include a test that reproduces the bug and proves it is fixed. For clarity, it may be useful to provide the test in a separate commit from the bug fix.
• If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

[lgtm-com]

This pull request fixes 1 alert when merging 18fb47c into f1db0c0 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging a38d365 into f1db0c0 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request fixes 1 alert when merging 1247088 into f1db0c0 - view on LGTM.com

fixed alerts:

• 1 for Unused variable, import, function or class

[tdonohue]

👍 Looks good to me. I tested it with an Item with 11 Bitstreams, and it works as described. On the simple Item view, the first 5 are displayed and you can display 5 more by clicking "Show more" (until no additional bitstreams can be listed). On the full item view, full pagination options exist, showing 5 bitstreams per page. Code and tests look good too! Thanks @Raf-atmire !

[tdonohue]

Merging as this was flagged for 1 Approval