Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): add the onOpenTab event #416

Merged
merged 2 commits into from
Sep 8, 2021
Merged

feat(editor): add the onOpenTab event #416

merged 2 commits into from
Sep 8, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Sep 8, 2021

Overview

增加 onOpenTab 事件

Resolved #414

Changes

  • 增加 onOpenTab事件,主要是对 editor.open 方法调用时进行监听,
  • 增加针对 onOpenTab 事件的单元测试

@wewoor wewoor requested a review from mortalYoung September 8, 2021 09:04
@wewoor wewoor self-assigned this Sep 8, 2021
@wewoor wewoor added the enhancement New feature or request label Sep 8, 2021
@wewoor wewoor added this to the 0.9.0-beta.1 milestone Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #416 (6a093f7) into main (5e68b1f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   81.27%   81.28%   +0.01%     
==========================================
  Files         177      177              
  Lines        4849     4852       +3     
  Branches     1044     1044              
==========================================
+ Hits         3941     3944       +3     
  Misses        899      899              
  Partials        9        9              
Impacted Files Coverage Δ
src/services/workbench/editorService.ts 97.92% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e68b1f...6a093f7. Read the comment docs.

Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit cdbff6f into main Sep 8, 2021
@wewoor wewoor deleted the feat/onOpenTab branch September 8, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an onOpenTab method to listen to the Editor open tab event
2 participants