Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updateTab will change the reference of current tab #779

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

mortalYoung
Copy link
Collaborator

@mortalYoung mortalYoung commented Jul 13, 2022

简介

  • 修复 updateTab 不会修改 current 索引的问题,这不符合 immutable

Related Issues

Closed #732

@mortalYoung mortalYoung added the bug Something isn't working label Jul 13, 2022
@mortalYoung mortalYoung self-assigned this Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #779 (1d94471) into main (819696e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         180      180           
  Lines        5783     5784    +1     
  Branches     1399     1400    +1     
=======================================
+ Hits         5264     5265    +1     
  Misses        513      513           
  Partials        6        6           
Impacted Files Coverage Δ
src/services/workbench/editorService.ts 97.91% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819696e...1d94471. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 3114bd5 into main Jul 14, 2022
@wewoor wewoor deleted the fix/updatetab branch July 14, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: updateTab doesn't change the reference of current
2 participants