Skip to content

Fix race condition in recv()'s usage of self.call. #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 3 commits into from
Sep 12, 2018
Merged

Fix race condition in recv()'s usage of self.call. #5935

theacodes merged 3 commits into from
Sep 12, 2018

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Sep 11, 2018

Fixes #5849

@theacodes theacodes requested a review from tseaver September 11, 2018 21:09
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018
@theacodes
Copy link
Contributor Author

theacodes commented Sep 11, 2018

@tseaver I'm not quite done with this, just pushing before I walk out the door.

@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

@theacodes I'll hold off until you ping me, then.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Sep 11, 2018
@theacodes
Copy link
Contributor Author

theacodes commented Sep 12, 2018

Hrm, it seems circleCI got hung up and timed out, but I can't reproduce it locally yet. I'm gonna re-trigger the build.

@theacodes
Copy link
Contributor Author

theacodes commented Sep 12, 2018

AppVeyor did as well.

@theacodes
Copy link
Contributor Author

theacodes commented Sep 12, 2018

Alright, @tseaver, this should be ready to review.

@theacodes theacodes force-pushed the fix-recv-race-condition branch from febd096 to 3f43005 Compare September 12, 2018 17:54
@theacodes theacodes merged commit 723b2a3 into master Sep 12, 2018
@theacodes theacodes deleted the fix-recv-race-condition branch September 12, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theacodes @tseaver @googlebot