Skip to content

Conversation

@qiwzhang
Copy link
Contributor

Otherwise, many users still using very old ESP image 1.16.0

Tag "1" is always points to the latest ESP image

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing to the latest version makes sense.

What's the easiest way to test this? As far as I can tell, it's not working on Cloud Run, I'm seeing the following error in stackdriver logging:

2019-09-04 10:50:56.890 PDT2019-09-04 17:50:56.889:INFO:oejs.SetUIDListener:main: Setting umask=02
2019-09-04 10:50:56.967 PDT2019-09-04 17:50:56.967:INFO:oejs.SetUIDListener:main: Opened ServerConnector@9629756{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
2019-09-04 10:50:56.967 PDT2019-09-04 17:50:56.967:INFO:oejs.SetUIDListener:main: Setting GID=999
2019-09-04 10:50:56.968 PDT2019-09-04 17:50:56.968:INFO:oejs.SetUIDListener:main: Setting UID=999
2019-09-04 10:50:56.974 PDT2019-09-04 17:50:56.974:INFO:oejs.Server:main: jetty-9.4.1.v20170120
2019-09-04 10:50:57.002 PDT2019-09-04 17:50:57.002:INFO:oejdp.ScanningAppProvider:main: Deployment monitor [file:///var/lib/jetty/webapps/] at interval 0
2019-09-04 10:50:57.690 PDTjava.io.IOException: Server returned HTTP response code: 403 for URL: https://clouddebugger.googleapis.com/v2/controller/debuggees/register at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1876) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474) at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254) at com.google.devtools.cdbg.debuglets.java.GcpHubClient.registerDebuggee(Unknown Source)
2019-09-04 10:51:03.320 PDTGET500 85 B 11.6 s Chrome 76  https://default20170420t14193-o4ykw4wyqq-uc.a.run.app/favicon.ico
2019-09-04 10:51:03.321 PDTMemory limit of 256M exceeded with 279M used. Consider increasing the memory limit, see https://cloud.google.com/run/docs/configuring/memory-limits

Also, if this is a Java container it probably should not be committed to the python repo.

@qiwzhang
Copy link
Contributor Author

qiwzhang commented Sep 4, 2019

It seems that you were seeing the wrong error log. Here we only have some kube deployment yaml files. We don't have anything related to Java.

The only way to test it is to follow this doc. That doc uses this deployment yaml file.

@gguuss
Copy link
Contributor

gguuss commented Sep 4, 2019

LGTM as it will match the other service.

@gguuss gguuss merged commit 0d582dd into GoogleCloudPlatform:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants