Skip to content

Conversation

@shubha-rajan
Copy link
Contributor

@shubha-rajan shubha-rajan commented Feb 5, 2020

  • Made service name consistent in steps 1, 2, and 3 of README
  • Removed beta command
  • Removed whitespace from step 3 so that it can be copy-pasted easily

Tested all commands locally to confirm that they work!

* Made service name consistent in steps 1, 2, and 3
* Removed beta command
* Removed whitespace from step 3 so that it can be copy-pasted easily
@shubha-rajan shubha-rajan requested a review from kurtisvg February 5, 2020 01:12
@shubha-rajan shubha-rajan requested a review from a team as a code owner February 5, 2020 01:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020

```sh
gcloud beta run deploy run-sql --image gcr.io/[YOUR_PROJECT_ID]/run-sql
gcloud run deploy run-sql --image gcr.io/[YOUR_PROJECT_ID]/run-mysql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still says run-sql, but below it says run-mysql. Is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope! missed that one. Fixed.

@kurtisvg kurtisvg assigned kurtisvg and unassigned crwilcox Feb 5, 2020
@shubha-rajan shubha-rajan requested a review from kurtisvg February 5, 2020 18:55
@kurtisvg kurtisvg merged commit 4624100 into master Feb 5, 2020
@kurtisvg kurtisvg deleted the shubha-rajan-patch-1 branch February 5, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants