fix: Update PrintNamespacesList to use a YAML parser for multiple manifest files (#9825)#9833
Merged
plumpy merged 1 commit intoGoogleContainerTools:release/v2.16from Jun 18, 2025
Merged
Conversation
…ifest files (GoogleContainerTools#9825) * Update PrintNamespacesList to break on YAML file separator '---' followed by a new line. * fix: Update PrintNamespacesList to break on YAML file separator '---' followed by a new line. * fix: update yaml line break character and add more tests * fix: use yaml parser to process multiple files * fix: add test for single manifest w break at end * fix: remove unnecessary conversion * fix: update import * fix: if resourceToInfoMap is empty, return nil * fix: format * fix: log fmt write error and update empty manifest (with just ---) handling * fix: format * fix: fix imports * fix: add test case
Darien-Lin
approved these changes
Jun 17, 2025
95fb592
into
GoogleContainerTools:release/v2.16
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PrintNamespacesList to break on YAML file separator '---' followed by a new line.
fix: Update PrintNamespacesList to break on YAML file separator '---' followed by a new line.
fix: update yaml line break character and add more tests
fix: use yaml parser to process multiple files
fix: add test for single manifest w break at end
fix: remove unnecessary conversion
fix: update import
fix: if resourceToInfoMap is empty, return nil
fix: format
fix: log fmt write error and update empty manifest (with just ---) handling
fix: format
fix: fix imports
fix: add test case