perf: Reduce decode overhead during pruning keys in the memtable#3415
Merged
v0y4g3r merged 20 commits intoGreptimeTeam:mainfrom Mar 8, 2024
Merged
perf: Reduce decode overhead during pruning keys in the memtable#3415v0y4g3r merged 20 commits intoGreptimeTeam:mainfrom
v0y4g3r merged 20 commits intoGreptimeTeam:mainfrom
Conversation
38 tasks
chore: fix compiler errors refactor: shard prune metrics
ebd00b0 to
69bdbf0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
- Coverage 85.05% 84.72% -0.33%
==========================================
Files 889 889
Lines 146427 146709 +282
==========================================
- Hits 124547 124303 -244
- Misses 21880 22406 +526 |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR improves the pruning speed of the new memtable
decode_value_at()method to decode a value at a specific position in the primary keyPrimaryKeyFilterto filter primary keys viadecode_value_at()ShardsandShardBuilderto reduce DataBatch returned to the partition readerChecklist
Refer to a related PR or issue link (optional)