Skip to content

feat: let alter table procedure can only alter physical table#3613

Merged
waynexia merged 2 commits intoGreptimeTeam:mainfrom
fengjiachun:feat/alter-table-rm-logical
Mar 29, 2024
Merged

feat: let alter table procedure can only alter physical table#3613
waynexia merged 2 commits intoGreptimeTeam:mainfrom
fengjiachun:feat/alter-table-rm-logical

Conversation

@fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said, we already have the AlterLogicalTablesProcedure for logical tables.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 29, 2024
@fengjiachun fengjiachun requested a review from waynexia March 29, 2024 08:34
@codecov
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 85.14%. Comparing base (f49cd0c) to head (d8170fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3613      +/-   ##
==========================================
- Coverage   85.41%   85.14%   -0.27%     
==========================================
  Files         932      932              
  Lines      155075   155142      +67     
==========================================
- Hits       132451   132096     -355     
- Misses      22624    23046     +422     

@waynexia waynexia changed the title feat: let alter table procedure can only alter physicale table feat: let alter table procedure can only alter physical table Mar 29, 2024
@waynexia waynexia added this pull request to the merge queue Mar 29, 2024
Merged via the queue into GreptimeTeam:main with commit 93da45f Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants