Skip to content

Made the code more readable#6

Merged
JasonWei512 merged 2 commits intoJasonWei512:developfrom
LeahScholten:develop
Dec 16, 2022
Merged

Made the code more readable#6
JasonWei512 merged 2 commits intoJasonWei512:developfrom
LeahScholten:develop

Conversation

@LeahScholten
Copy link
Contributor

Made needlessly explicit returns implicit, put variables in the format string, removed an unnecessary check when handling user input, decreased indentation depth, replaced a return true with a return of the result of the comparison.

Michael Scholten added 2 commits December 15, 2022 21:40
…t string, removed an unnecessary check when handling user input, decreased indentation depth, replaced a return true with a return of the result of the comparison.
…structs with in their functions for readability, made functions which don't influence other code const to add flexibility and readability, removed a clone of a caused by a call to , made the start_playing function shorter by splitting it into multiple smaller functions, removed a redundant closure, removed async from a function without await, replaced an match with a
@LeahScholten
Copy link
Contributor Author

Added the following modifications:
Derived Eq where possible for more flexibility, replaced the name of structs with Self in their functions for readability, made functions which don't influence other code const to add flexibility and readability, removed a clone of a String caused by a call to .to_owned(), made the start_playing function shorter by splitting it into multiple smaller functions, removed a redundant closure, removed async from a function without await, replaced an Option match with a map_or_else

@JasonWei512 JasonWei512 merged commit d439344 into JasonWei512:develop Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants