Update rodio dependency#9
Merged
JasonWei512 merged 1 commit intoJasonWei512:developfrom Jan 3, 2023
shnewto:develop
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading through some the issues referenced as related to #7, I experimented with updating the rodio dependency to the most current and it solved the issue for me 🙀
Probably worth testing yourself @JasonWei512, this seems kinda too easy... but for my tests, with code-radio running, I toggled the system audio output device. Built with rodio 0.15.0, the code-radio audio didn't change output devices. Built with rodio 0.16.0 code-radio audio changed output devices 😄
Thanks for taking a look!