Add a few permissions and fix oracle server errors #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the --seed command
Member
Author
|
For our peace of mind, I would appreciate a post hoc review of these changes at some point, @elenadimitrova. |
Contributor
elenadimitrova
left a comment
There was a problem hiding this comment.
I think this is fine. Even the suggested modifiers will become obsolete with Filip's implementation in #224. There we extend the permissions of addDomain to the entire adminRole group as defined in Authority.
| skillExists(_skillId) | ||
| globalSkill(_skillId) | ||
| { | ||
| require(tasks[_id].roles[MANAGER].user == msg.sender); |
Contributor
There was a problem hiding this comment.
Our modifier vs inline logic argument again :)
Like here, for me this should have been managerOnly modifier in all three instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's going to be a public instance of the network anywhere, we need to make sure that people can't mess it up. This adds permissions to
addGlobalSkill(colony owner only, and only works from metaColony, so effectively only the metaColony's owner)addDomain(colony owner only)setTaskRoleUser,setTaskDomain,setTaskSkillare now restricted to the manager of the task.I also took the opportunity to fix a couple of issues floating around in the reputation miner that I needed fixed.