chore(acme): standardize redis configuration#12300
Merged
Conversation
6729d6a to
75f4bc4
Compare
75f4bc4 to
2b317d0
Compare
dc4a0e8 to
0ad6ba1
Compare
This was referenced Jan 8, 2024
a8c7332 to
aecbd9f
Compare
jschmid1
requested changes
Jan 9, 2024
changelog/unreleased/kong/standardize-redis-conifguration-acme.yml
Outdated
Show resolved
Hide resolved
spec/05-migration/plugins/acme/migrations/003_350_to_360_spec.lua
Outdated
Show resolved
Hide resolved
5d5eb72 to
bcdf751
Compare
ACME right now has new config structure that reuses common redis connection configuration. With introduction of new fields for redis configuration the old ones should still be available to user up until kong 4.0 version. KAG-3388
bcdf751 to
3b8fbb8
Compare
jschmid1
approved these changes
Jan 11, 2024
Contributor
jschmid1
left a comment
There was a problem hiding this comment.
looks good! nice work 🚀
locao
approved these changes
Jan 11, 2024
Contributor
locao
left a comment
There was a problem hiding this comment.
Just a log message that seems to need a fix, otherwise LGTM 🚀
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Collaborator
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12300-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12300-to-master-to-upstream
git checkout -b cherry-pick-12300-to-master-to-upstream
ancref=$(git merge-base 15d6f4cec8f6253ff73f157cb37d1a2cdce8cb94 c52a2c8d064412a4fb2842d9ecc01d093d8fcbcd)
git cherry-pick -x $ancref..c52a2c8d064412a4fb2842d9ecc01d093d8fcbcd |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACME right now has new config structure that reuses common redis connection configuration.
Many plugins differ in the way Redis is configured. The goal of this PR is to introduce a standard Redis config schema that could be shared across plugins.
Other PRs
This is the first in the chains of PRs that standardize Redis configuration.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
KAG-3388