Integration merge #34
Conversation
…e-based fallback to solve 4369 (sst#4572) Co-authored-by: knanao <[email protected]> Co-authored-by: knanao <[email protected]>
…dling Updates the @solidjs/start dependency to latest version and removes deprecated getResponseHeaders usage from auth callback. Also adds error handling for workspace ID lookup to prevent redirect failures.
…r calls (sst#4653) Co-authored-by: Aiden Cline <[email protected]>
Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Github Action <[email protected]>
…ttern and 1.0.109 versions
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Match when={local.size === "compact"}> | ||
| <button | ||
| data-slot="message-nav-tick-button" | ||
| data-active={message.id === local.current?.id || undefined} | ||
| onClick={handleClick} | ||
| > | ||
| <div data-slot="message-nav-tick-button" data-active={message.id === local.current?.id || undefined}> | ||
| <div data-slot="message-nav-tick-line" /> | ||
| </button> | ||
| </div> |
There was a problem hiding this comment.
Restore click handling in compact message nav
In MessageNav the compact branch now renders a plain div (lines 31‑34) instead of the previous button with onClick={handleClick}. As a result handleClick never fires when size="compact", so the ticks no longer change the active message. Any view that supplies the compact variant (e.g., narrow breakpoints or layouts with diffs) now leaves users unable to navigate between messages.
Useful? React with 👍 / 👎.
No description provided.