Skip to content

Conversation

@shubhadeepd
Copy link
Collaborator

Signed-off-by: Shubhadeep Das <[email protected]>
@pranjaldoshi96
Copy link

pranjaldoshi96 commented Jan 2, 2024

LGTM!

@shubhadeepd shubhadeepd self-assigned this Jan 2, 2024
@shubhadeepd shubhadeepd requested a review from jliberma January 2, 2024 05:40
Copy link
Contributor

@jliberma jliberma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jliberma
Copy link
Contributor

jliberma commented Jan 2, 2024

@shubhadeepd @sumitkbh -- Launchpad pulls from v0.1.0. So does the Helm chart. Please confirm that this fix will fix it in all the tagged branches as well as main.

@robdaly
Copy link

robdaly commented Jan 3, 2024

@shubhadeepd @sumitkbh -- Launchpad pulls from v0.1.0. So does the Helm chart. Please confirm that this fix will fix it in all the tagged branches as well as main.

Or, provide the tagged version for LaunchPad to target for future trial requests.

@shubhadeepd
Copy link
Collaborator Author

@shubhadeepd @sumitkbh -- Launchpad pulls from v0.1.0. So does the Helm chart. Please confirm that this fix will fix it in all the tagged branches as well as main.

Or, provide the tagged version for LaunchPad to target for future trial requests.

@robdaly can you use the main branch for now? These types of breaking changes (due to third-party libraries) may be frequent, and it isn't easy to maintain/backport the fix in every tagged release branch. We can ensure the main branch will be always functional. You can use the v0.3.0 branch which will be forked from main around January 20th with this fix, and use the main branch till then.

@shubhadeepd shubhadeepd merged commit a56859d into main Jan 3, 2024
@shubhadeepd shubhadeepd deleted the fix-minio-version branch January 3, 2024 13:58
anniesurla pushed a commit to anniesurla/GenerativeAIExamples that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'BaseHTTPResponse' from 'urllib3.response'

5 participants