Improve performance of Get-GitHubContent

[HowardWolosky]

Description

The call to ConvertTo-SmarterObject was adding a significant amount of time to the execution of Get-GitHubContent.

    Set-GitHubConfiguration -DisableSmarterObjects:$false
    Measure-Command { $c = Get-GitHubContent -OwnerName microsoft -RepositoryName PowerShellForGitHub -Path README.md }
    # This averages to be around 1.2 seconds

    Set-GitHubConfiguration -DisableSmarterObjects:$true
    Measure-Command { $c = Get-GitHubContent -OwnerName microsoft -RepositoryName PowerShellForGitHub -Path README.md }
    # This averages to be around 14 seconds

The reasoning behind this was that the return of Invoke-WebRequest for this repo's README.md was an array of [int32] that contained 22,000+ entries (one byte per entry). Because the array was created by ConverFrom-Json, each [int32] was also an [object], which meant that it was considered a [PSCustomObject] inside of ConverTo-SmarterObject, which caused it to do a lot of unnecessary work. Piping in 22,000 objects and doing all of that unnecessary work to end up just calling Write-Output on the original value took a lot of time.

The fix here was to skip trying to convert the result to a smarter object if it wasn't going to be a convertible object in the first place.

I also added in protection directly to ConverTo-SmarterObject as well. It made things better than the current runtime, but still twice as slow as not calling it in the first place (average runtime of above command was 3.5 seconds when we allowed it to go into the command and then do nothing).

This doesn't end up saving much time with the execution of Tests/GitHubContents.tests.ps1 because the file being returned is so small, but this should have some nice user experience improvements in practical usage.

Issues Fixed

None

References

n/a

Checklist

• You actually ran the code that you just wrote, especially if you did just "one last quick change".
• [] Comment-based help added/updated, including examples.
• Static analysis is reporting back clean.
• New/changed code adheres to our coding guidelines.
• Changes to the manifest file follow the manifest guidance.
• Unit tests were added/updated and are all passing. See testing guidelines.
• Relevant usage examples have been added/updated in USAGE.md.
• If desired, ensure your name is added to our Contributors list

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HowardWolosky]

/azp run PowerShellForGitHub-CI

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).