Conversation
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I've noted some requested changes for you to make.
HowardWolosky
left a comment
There was a problem hiding this comment.
Good update. Minor issues remaining.
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks for the updates. Minor changes requested. Will be interested in hearing from @danbelcher-MSFT as well.
| $existingMilestone.title | Should be $defaultMilestoneTitle1 | ||
| } | ||
|
|
||
| It "Should have the expected state" { |
There was a problem hiding this comment.
My nitpick here is that these test names are generic and so don't tell you anything about what is actually being tested. When you run the tests, you should see:
For creating a new milestone:
...
'Should be in the closed state'
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
|
Can you please get this branch up-to-date with what's in master? There are currently conflicts preventing the merge. |
|
@HowardWolosky I had merged master into this branch before you made that conflicts comment, and I'm not seeing any conflicts anymore. The only thing blocking the merge now is that "The base branch restricts merging to authorized users" and I'm not authorized. I assume you are able to merge the PR? |
|
Thanks -- issue was on my end. GitHub was saying that I couldn't |
Added functionality for the milestones api