Fix typo that prevent tag(s) to be assigned to new issue#76
Merged
HowardWolosky merged 1 commit intomicrosoft:masterfrom Dec 14, 2018
lazywinadmin:master
Merged
Fix typo that prevent tag(s) to be assigned to new issue#76HowardWolosky merged 1 commit intomicrosoft:masterfrom lazywinadmin:master
HowardWolosky merged 1 commit intomicrosoft:masterfrom
lazywinadmin:master
Conversation
HowardWolosky
approved these changes
Dec 14, 2018
Contributor
HowardWolosky
left a comment
There was a problem hiding this comment.
Wow...thanks for the fix, François-Xavier! Looks like we need to see why this didn't get caught with the unit tests.
HowardWolosky
added a commit
to HowardWolosky/PowerShellForGitHub
that referenced
this pull request
Dec 14, 2018
Issue microsoft#76 recent fixed a bug where Labels were not being correctly added to Issues at the time of creation. This new UT will ensure that is always tested going forward. Additionally, this updates all UT's to disable telemetry and enable logging of the request body to ease debugging.
HowardWolosky
added a commit
that referenced
this pull request
Dec 14, 2018
Issue #76 recent fixed a bug where Labels were not being correctly added to Issues at the time of creation. This new UT will ensure that is always tested going forward. Additionally, this updates all UT's to disable telemetry and enable logging of the request body to ease debugging.
HowardWolosky
added a commit
to HowardWolosky/PowerShellForGitHub
that referenced
this pull request
Dec 14, 2018
Similar to microsoft#76, `Update-GitHubIssue` was passing in the provided labels as `label` instead of `labels` in the request body.
HowardWolosky
added a commit
that referenced
this pull request
Dec 14, 2018
Similar to #76, `Update-GitHubIssue` was passing in the provided labels as `label` instead of `labels` in the request body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using:
The labels are not assigned to the new issue.
This PR fix the problem, just a typo.