fix: normalize tool call IDs for cross-provider compatibility via OpenRouter #10102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review complete. No issues found. The latest commit correctly moves Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Some providers (like Mistral) require tool call IDs to be: - Only alphanumeric characters (a-z, A-Z, 0-9) - Exactly 9 characters in length This caused errors when conversations with tool calls from one provider (e.g., OpenAI's call_xxx format) were routed to Mistral via OpenRouter. Solution: - Added normalizeToolCallId() function that strips non-alphanumeric characters and pads/truncates to exactly 9 characters - Added modelId option to convertToOpenAiMessages() that conditionally normalizes IDs only when the model contains 'mistral' - OpenRouter now passes modelId to enable normalization for Mistral models - Direct Mistral provider uses convertToMistralMessages() which always normalizes IDs This scoped approach only affects Mistral models, avoiding any potential impact on the 15+ other providers using OpenAI-compatible format. Example transformations: - call_5019f900a247472bacde0b82 → call5019f - toolu_01234567890abcdef → toolu0123 - weather-123 → weather12
87e8348 to
72eddd7
Compare
cte
reviewed
Dec 16, 2025
…OpenAiMessages Addresses PR feedback about separation of concerns. The convertToOpenAiMessages function now accepts an optional normalizeToolCallId function instead of checking for 'mistral' in the modelId. This allows callers to flexibly declare the tool call ID format without the transform module needing to know about provider-specific requirements.
Moves the tool call ID normalization function to mistral-format.ts with explicit Mistral naming (normalizeMistralToolCallId) since Mistral is the only provider that requires this specific 9-character alphanumeric ID format. This better separates concerns by keeping provider-specific logic in the appropriate module while keeping the generic convertToOpenAiMessages function flexible via the optional normalizeToolCallId callback.
Collaborator
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some providers (like Mistral) require tool call IDs to be:
This caused errors when conversations with tool calls from one provider (e.g., OpenAI's
call_xxxformat) were routed to Mistral via OpenRouter.Error Example
Solution
normalizeToolCallId()function that strips non-alphanumeric characters and pads/truncates to exactly 9 charactersmodelIdoption toconvertToOpenAiMessages()that conditionally normalizes IDs only when the model contains 'mistral'convertToMistralMessages()which always normalizes IDsThis scoped approach only affects Mistral models, avoiding any potential impact on the 15+ other providers using OpenAI-compatible format.
Example Transformations
call_5019f900a247472bacde0b82→call5019ftoolu_01234567890abcdef→toolu0123weather-123→weather12Testing
Important
Adds tool call ID normalization for Mistral models in OpenRouter to ensure compatibility with strict ID requirements.
normalizeMistralToolCallId()inmistral-format.tsto ensure tool call IDs are alphanumeric and 9 characters long.convertToOpenAiMessages()inopenai-format.tsto optionally usenormalizeToolCallIdfor Mistral models.OpenRouterHandlerinopenrouter.tsto pass normalization function for Mistral models.normalizeMistralToolCallId()inmistral-format.spec.ts.openai-format.spec.tsto cover normalization scenarios.This description was created by
for 58410fe. You can customize this summary. It will automatically update as commits are pushed.