Format microsecond in prepare_constant#929
Merged
tyt2y3 merged 8 commits intoSeaQL:masterfrom Aug 2, 2025
Merged
Conversation
Expurple
approved these changes
Jul 30, 2025
tyt2y3
added a commit
that referenced
this pull request
Aug 2, 2025
Fixed the issue where milliseconds were truncated when formatting `Value::Constant` - [Postgres](https://www.postgresql.org/docs/current/datatype-datetime.html#DATATYPE-DATETIME-INPUT-TIMES) Support microseconds - [Mysql](https://dev.mysql.com/doc/refman/8.4/en/fractional-seconds.html) Support microseconds - [Sqlite](https://sqlite.org/lang_datefunc.html) Support milliseconds, ignore extra digits <!-- mention the related issue --> - Closes #808 - [x] Fixed the issue where microseconds were truncated when formatting `Value::Constant` --------- Co-authored-by: Chris Tsang <chris.2y3@outlook.com>
🎉 Released In 0.32.7 🎉Thank you everyone for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Fixed the issue where milliseconds were truncated when formatting
Value::ConstantSupport microseconds
Support microseconds
Support milliseconds, ignore extra digits
SimpleExpr::Constantconversion to string drops second fractions #808Bug Fixes
Value::Constant