Allow clusters that do not use kubeproxy to disable presleep#416
Merged
cognifloyd merged 1 commit intomasterfrom Dec 16, 2024
Merged
Allow clusters that do not use kubeproxy to disable presleep#416cognifloyd merged 1 commit intomasterfrom
cognifloyd merged 1 commit intomasterfrom
Conversation
When I tried using "0", it was somehow converted to an integer in the yaml file causing some failures during helm upgrade. So, this also adds quotes around the preStopSleep. Also, the changelog was missing the PR that added the preStopSleep, so add it, and fix the order of another changelog entry to follow the merge order and link to the PR instead of the issue.
db0128c to
537032a
Compare
mweinberg-cm
approved these changes
Dec 11, 2024
winem
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a conditional to skip adding the preStop sleep (added in #382) for clusters that do not use kubelet. My cluster, for example, uses the Calico eBPF-based dataplane, so it does not rely on kubelet or iptables.
When I tried using "0" to skip this, it was somehow converted to an integer in the generated yaml file causing some failures during helm upgrade. So, this also adds quotes around the preStopSleep.
Also, the changelog was missing the PR that added the preStopSleep, so add it, and fix the order of another changelog entry to follow the merge order and link to the PR instead of the issue.