Migrate Adding Inline Token test to Playwright#52020
Migrate Adding Inline Token test to Playwright#52020Mamaduka merged 4 commits intoWordPress:trunkfrom
Conversation
|
Hi @kevin940726, I have pushed the code with all the changes/feedbacks being addressed but somehow the test is failing while adding block but in my local it is passing successfully. Could you please check and suggest here? Thanks! |
| pageUtils, | ||
| } ) => { | ||
| // Create a paragraph. | ||
| await page.click( 'role=button[name="Add default block"i]' ); |
There was a problem hiding this comment.
| await page.click( 'role=button[name="Add default block"i]' ); | |
| await editor.canvas.click( 'role=button[name="Add default block"i]' ); |
I think this will fix the test failure.
|
I hope you are doing great! The feedbacks have been addressed and I have pushed the code but CI is failing but it's not related to test case I worked upon. Could you please check once and let me know the further steps? Thanks! |
|
@pooja-muchandikar, the failing e2e test isn't related to this PR and was recently fixed - #52283. Can you rebase your branch on top of the latest trunk? This should resolve the issue. |
|
Sure @Mamaduka |
|
Hi @Mamaduka, I went through the documentation you shared and tried the steps but somehow it shows everything is up-to-date.
|
|
@pooja-muchandikar, did you first fetch upstream and merge the trunk into your trunk branch before rebasing? Assuming you've a standard git setup for working with Gutenberg, that message is incorrect. The repos trunk has a lot of new commits. |
|
Hi @Mamaduka,
Yes, I am using the standard git setup only. I have rebased it again and pushed the commit, now all tests are passing but Puppeteer is failing. |
|
I restarted the tests and will merge the PR once they're green. Thanks, @pooja-muchandikar! |
|
Thank you @Mamaduka 🙂 |




What?
Part of #38851.
Migrate adding-inline-tokens.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/various/adding-inline-tokens.spec.js