Skip to content

Migrate Adding Inline Token test to Playwright#52020

Merged
Mamaduka merged 4 commits intoWordPress:trunkfrom
pooja-muchandikar:migrate/adding-inline-token-tests
Jul 6, 2023
Merged

Migrate Adding Inline Token test to Playwright#52020
Mamaduka merged 4 commits intoWordPress:trunkfrom
pooja-muchandikar:migrate/adding-inline-token-tests

Conversation

@pooja-muchandikar
Copy link
Copy Markdown
Contributor

What?

Part of #38851.
Migrate adding-inline-tokens.test.js to its Playwright version.

Why?

Part of #38851.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test:e2e:playwright test/e2e/specs/editor/various/adding-inline-tokens.spec.js

@pooja-muchandikar
Copy link
Copy Markdown
Contributor Author

Hi @kevin940726,

I have pushed the code with all the changes/feedbacks being addressed but somehow the test is failing while adding block but in my local it is passing successfully. Could you please check and suggest here?

image

Thanks!

pageUtils,
} ) => {
// Create a paragraph.
await page.click( 'role=button[name="Add default block"i]' );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await page.click( 'role=button[name="Add default block"i]' );
await editor.canvas.click( 'role=button[name="Add default block"i]' );

I think this will fix the test failure.

@skorasaurus skorasaurus added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jul 3, 2023
@pooja-muchandikar
Copy link
Copy Markdown
Contributor Author

Hi @Mamaduka, @kevin940726

I hope you are doing great!

The feedbacks have been addressed and I have pushed the code but CI is failing but it's not related to test case I worked upon.

image

Could you please check once and let me know the further steps?

Thanks!

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Jul 6, 2023

@pooja-muchandikar, the failing e2e test isn't related to this PR and was recently fixed - #52283.

Can you rebase your branch on top of the latest trunk? This should resolve the issue.

@pooja-muchandikar
Copy link
Copy Markdown
Contributor Author

Sure @Mamaduka

@pooja-muchandikar
Copy link
Copy Markdown
Contributor Author

Hi @Mamaduka,

I went through the documentation you shared and tried the steps but somehow it shows everything is up-to-date.

Screenshot 2023-07-06 at 3 02 31 PM

@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Jul 6, 2023

@pooja-muchandikar, did you first fetch upstream and merge the trunk into your trunk branch before rebasing?

git fetch upstream
git checkout trunk
git merge upstream/trunk

Assuming you've a standard git setup for working with Gutenberg, that message is incorrect. The repos trunk has a lot of new commits.

@pooja-muchandikar
Copy link
Copy Markdown
Contributor Author

Hi @Mamaduka,

Assuming you've a standard git setup for working with Gutenberg, that message is incorrect. The repos trunk has a lot of new commits.

Yes, I am using the standard git setup only.

I have rebased it again and pushed the commit, now all tests are passing but Puppeteer is failing.

image


@Mamaduka
Copy link
Copy Markdown
Member

Mamaduka commented Jul 6, 2023

I restarted the tests and will merge the PR once they're green. Thanks, @pooja-muchandikar!

@Mamaduka Mamaduka merged commit 4baf207 into WordPress:trunk Jul 6, 2023
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 6, 2023
@pooja-muchandikar pooja-muchandikar deleted the migrate/adding-inline-token-tests branch July 6, 2023 12:02
@pooja-muchandikar
Copy link
Copy Markdown
Contributor Author

Thank you @Mamaduka 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants