Skip to content

Conversation

@yuhan6665
Copy link
Member

No description provided.

@RPRX
Copy link
Member

RPRX commented Sep 24, 2025

这样是能治本还是

@yuhan6665
Copy link
Member Author

根据问题描述应该可以

@RPRX
Copy link
Member

RPRX commented Oct 14, 2025

想合并这个 PR 但貌似问题仍然存在 #5169 (comment) #4878 (comment) ,为了避免合入新 bug 再等一等吧

@RPRX RPRX force-pushed the main branch 2 times, most recently from 9ebd6ad to d418401 Compare November 23, 2025 00:31
@RPRX
Copy link
Member

RPRX commented Nov 24, 2025

这个有验证解决了吗?似乎他们提到了一个测试域名

@yuhan6665
Copy link
Member Author

This is supposed to fix
可是 Vision 没有考虑 TLS 记录是否完整,就把部分 TLS 记录通过 Vision 层发送给客户端,然后剩余的 TLS 记录留在了 TCP 层
But in my (limited) testing, I cannot verify a tls record (first record after the handshake) be broken into different read. I asked the original reporter but received no response

@yuhan6665 yuhan6665 marked this pull request as ready for review November 29, 2025 15:56
@yuhan6665
Copy link
Member Author

作者也说了不好复现 #5169 (comment)
那么跟我测试差不多 你们 review 一下代码应该可以合

@RPRX RPRX changed the title Vision: check tls record is complete XTLS Vision: Check TLS record isComplete Nov 30, 2025
@RPRX RPRX merged commit c6afcd5 into main Nov 30, 2025
78 checks passed
@RPRX RPRX deleted the vision branch November 30, 2025 10:28
@RPRX
Copy link
Member

RPRX commented Nov 30, 2025

#5169 (comment) 这个问题可能修好了,但是 #4878 (comment) 应该是另一个问题,所以那个 issue 先保持 open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants