Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTF-8 normalization #207

Open
jtagcat opened this issue Apr 24, 2022 · 2 comments · May be fixed by #220
Open

UTF-8 normalization #207

jtagcat opened this issue Apr 24, 2022 · 2 comments · May be fixed by #220

Comments

@jtagcat
Copy link

jtagcat commented Apr 24, 2022

Please complete the following information

  • Installation Type: Docker
  • Have you tried using the latest docker image / code base yes

To Reproduce
Steps to reproduce the behavior:

  1. Add feed https://feeds.soundcloud.com/users/soundcloud:users:317878409/sounds.rss
  2. Filename of downloaded: Miljardi-dollari-küsimus-Timo-Rein.mp3
  3. Wanted: Miljardi-dollari-küsimus-Timo-Rein.mp3

(They are different to computers!)

Additional context
Syncthing only syncs UTF-8 items. It's annoying elsewhere as well.
@akhilrex
Copy link
Owner

Is there any specific reason you want to retain the exact file name? There is a rather strict name sanitization logic built so that downloading and saving doesnt break. The name is retained as is in the database as well as the feed that the system generates.

Can you share the use case with me?

@jtagcat
Copy link
Author

jtagcat commented Apr 25, 2022 •
edited
Loading

I don't want to retain the exact filename. I want the result to be UTF-8.

Right now:

  1. podgrab downloads file
  2. Syncthing renames it to UTF-8 (2. -> 3.)
  3. podgrab re-downloads the file
  4. conflict (2 files: Miljardi-dollari-küsimus-Timo-Rein.mp3 and Miljardi-dollari-küsimus-Timo-Rein.mp3 exist (they are different!))

@jtagcat jtagcat linked a pull request Jun 24, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

convert incoming filenames to UTF-8 jtagcat/podgrab
2 participants
@akhilrex @jtagcat