Use thread-safe list to store conversations

While the methods manipulating or accessing the list are synchronized,
the ConversationContainer class is also subject to serialization.

Issue: SWF-1668

Author: rstoyanchev

spring-webflow/src/main/java/org/springframework/webflow/conversation/impl/ConversationContainer.java

@@ -19,6 +19,7 @@
 import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -37,6 +38,7 @@
  * {@link SessionBindingConversationManager}.
  *
  * @author Erwin Vervaet
+ * @author Rossen Stoyanchev
  */
 public class ConversationContainer implements Serializable {
 
@@ -63,7 +65,7 @@ public class ConversationContainer implements Serializable {
 	public ConversationContainer(int maxConversations, String sessionKey) {
 		this.maxConversations = maxConversations;
 		this.sessionKey = sessionKey;
-		this.conversations = new ArrayList<ContainedConversation>();
+		this.conversations = new CopyOnWriteArrayList<ContainedConversation>();
 	}
 
 	/**
@@ -135,7 +137,7 @@ public synchronized void removeConversation(ConversationId id) {
 		for (Iterator<ContainedConversation> it = conversations.iterator(); it.hasNext();) {
 			ContainedConversation conversation = it.next();
 			if (conversation.getId().equals(id)) {
-				it.remove();
+				conversations.remove(conversation);
 				break;
 			}
 		}