Skip to content

feat: saved query preview modal#11135

Merged
nytai merged 4 commits intoapache:masterfrom
preset-io:lily/saved-query-preview
Oct 5, 2020
Merged

feat: saved query preview modal#11135
nytai merged 4 commits intoapache:masterfrom
preset-io:lily/saved-query-preview

Conversation

@lilykuang
Copy link
Member

@lilykuang lilykuang commented Oct 1, 2020

SUMMARY

  • Saved Query Preview Modal
  • press j/ArrorwUp to navigate to previous query; press k/ArrowDown to navigate to next query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://www.loom.com/share/7c507cabafb4443fa9e76997bb8cdc72

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this prop to highlightRowId or something that's a little less tied to the current use case?

@lilykuang lilykuang marked this pull request as ready for review October 2, 2020 23:21
@lilykuang lilykuang requested a review from nytai October 2, 2020 23:40
@lilykuang lilykuang force-pushed the lily/saved-query-preview branch from f873236 to f6d597b Compare October 3, 2020 21:22
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nytai nytai merged commit 152315d into apache:master Oct 5, 2020
@nytai nytai deleted the lily/saved-query-preview branch October 5, 2020 23:22
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants