[Bootstrap] Fix spaces in Xcode issue#669
Merged
aciidgh merged 2 commits intoswiftlang:masterfrom Sep 24, 2016
Merged
Conversation
ddunbar
reviewed
Sep 19, 2016
Utilities/bootstrap
Outdated
| '-o', pipes.quote(link_output_path)] | ||
| if args.sysroot: | ||
| link_command.extend(["-sdk", args.sysroot]) | ||
| link_command.extend(["-sdk", pipes.quote(args.sysroot)]) |
Contributor
There was a problem hiding this comment.
This doesn't feel right, something else must be wrong here... we should be passing each argument in this array literally.
I think the actual probably might be in how we pass this command to swift-build-tool, maybe we are using the old arguments form?
Contributor
Author
There was a problem hiding this comment.
Yes its using the old arguments form but using array literal did not work because of some commands were separated by a ;
Contributor
Author
There was a problem hiding this comment.
args: rm -f /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/lib/PackageDescription.a ; ar cr /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/lib/PackageDescription.a /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/PackageDescription.build/JSON.o /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/PackageDescription.build/Package.o /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/PackageDescription.build/Product.o /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/PackageDescription.build/Target.o /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/PackageDescription.build/Version+StringLiteralConvertible.o /Users/ankit/workspace/opensource/swift.org/swiftpm/.build/.bootstrap/PackageDescription.build/Version.o
Contributor
There was a problem hiding this comment.
Good news: llbuild now has an archive tool which embeds this logic, so we can just switch to that.
Part of this bug: - https://bugs.swift.org/browse/SR-2650 - <rdar://problem/28318153> SR-2650 Can't build swiftpm with using Xcode that has a whitespace in its name
- https://bugs.swift.org/browse/SR-2650 - <rdar://problem/28318153> SR-2650 Can't build swiftpm with using Xcode that has a whitespace in its name
96c3cef to
cb30c86
Compare
Contributor
Author
|
@ddunbar done |
Contributor
|
LGTM |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test linux |
1 similar comment
Contributor
|
@swift-ci please test linux |
Contributor
|
LGTM |
Contributor
Author
|
@swift-ci please test linux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdk and compiler path needed escaping.
that has a whitespace in its name