[SE-0040] Replace '=' with ':' before attribute argument.#1537
Merged
lattner merged 3 commits intoswiftlang:masterfrom Mar 12, 2016
Merged
[SE-0040] Replace '=' with ':' before attribute argument.#1537lattner merged 3 commits intoswiftlang:masterfrom
lattner merged 3 commits intoswiftlang:masterfrom
Conversation
include/swift/AST/Attr.h
Outdated
Contributor
There was a problem hiding this comment.
I think we want a space after the colon.
Contributor
Author
There was a problem hiding this comment.
That is the case in ASTPrinter and stdlib. I'll update this doc.
Contributor
Author
There was a problem hiding this comment.
But I think that would hide CI results. So after that.
Contributor
|
@swift-ci Please test |
Contributor
|
Heh, thanks. It certainly seems like a highly controversial proposal! :-) |
Contributor
|
@swift-ci Please test |
7571347 to
7ea787f
Compare
Implements [SE-0040](https://github.com/apple/swift-evolution/blob/master/proposals/0040-attributecolons.md). When specifying arguments for attributes, both '=' and ':' are now accepted. But '=' will generate a deprecation warning.
lattner
added a commit
that referenced
this pull request
Mar 12, 2016
[SE-0040] Replace '=' with ':' before attribute argument.
Contributor
|
Awesome, merged and tests pass for me, thank you! |
Contributor
Author
|
Great. Thanks Chris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Note: at the time this PR is submitted, SE-0040 is still under review. I'm leaving this here just in case this wild proposal gets accepted.SE-0040 has been approved.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.