Skip to content

Runtime: Provide ABI space for source location info in unconditional casts.#21102

Merged
jckarter merged 1 commit intoswiftlang:masterfrom
jckarter:unconditional-cast-source-loc-abi
Dec 8, 2018
Merged

Runtime: Provide ABI space for source location info in unconditional casts.#21102
jckarter merged 1 commit intoswiftlang:masterfrom
jckarter:unconditional-cast-source-loc-abi

Conversation

@jckarter
Copy link
Contributor

@jckarter jckarter commented Dec 6, 2018

Currently ignored, but this will allow future compilers to pass down source location information for cast
failure runtime errors without backward deployment constraints.
rdar://problem/46543048

…casts.

Currently ignored, but this will allow future compilers to pass down source location information for cast
failure runtime errors without backward deployment constraints.
@jckarter
Copy link
Contributor Author

jckarter commented Dec 6, 2018

@swift-ci Please test

@jckarter jckarter requested a review from mikeash December 6, 2018 23:04
Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@jckarter
Copy link
Contributor Author

jckarter commented Dec 7, 2018

(Note that since this affects the runtime ABI, I'm holding off on merging this based on whether the corresponding PR for 5.0 #21103 gets accepted.)

@jckarter jckarter merged commit b2ceb4b into swiftlang:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants