[test] SR-1238: Add test for UnsafePointer and UnsafeMutablePointer conformance to Comparable#2269
Merged
gribozavr merged 2 commits intoswiftlang:masterfrom Apr 22, 2016
Conversation
…onformance to Comparable
Contributor
|
@swift-ci Please test |
| 0x00000002, | ||
| 0xFFFFFFFF, | ||
| 0x00001111 | ||
| ].map { ($0, ${SelfType}(bitPattern: $0)!) } |
Contributor
There was a problem hiding this comment.
It would be good to throw in some 64-bit values if we are on a 64-bit platform (see #ifs in tests above).
Contributor
Author
|
AFAICT CI failed with an unrelated failure. I pushed a new commit with 64 bit values as requested however. |
Contributor
Contributor
|
Should AutoreleasingUnsafeMutablePointer be included? It's also Strideable. Should OpaquePointer be included? It's not Strideable, but it probably still makes sense to be Comparable. |
Contributor
|
@jrose-apple Thank you, we are forgetting about other pointer types again! I think it makes sense for them to be comparable. |
Contributor
Author
|
I'll open a separate PR for those! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Added tests for
Comparableconformance ofUnsafePointerandUnsafeMutablePointerResolved bug number: (SR-1238)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.