Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Python2 support #75

Closed
iivanov-qb opened this issue Jul 25, 2023 · 1 comment
Closed

Broken Python2 support #75

iivanov-qb opened this issue Jul 25, 2023 · 1 comment

Comments

@iivanov-qb
Copy link
Contributor

#72 unintentionally broke the Python2 support, as tomli supports only Python3. Version 1.7.5 of flake8-requirements still works fine on Python2.

I see that you are preparing version 2.0 which officially removes the Python2 support, but I think that it is still good idea to create v1.7.9, fixing the Python2 support, conditionally using toml for Python2 and tomli for Python3. As now, whoever tries to install flake8-requirements for Python2 will end up with error, as pip would take v1.7.8, which is marked as Python2 supporting, but is already broken.

I could help with a PR, if you think it is a good idea to do this.

@arkq
Copy link
Owner

arkq commented Jul 25, 2023

Ooo I see. If you can provide a PR (or a diff attached to that issue) I'll be glad. I'm afraid I won't be able to test things with python2.... I will create a bug fix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants