-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rules checking the same violation #2714
Comments
Agreed. Not sure which to "remove" (i.e., treat as the canonical rule, as opposed to the redirect), but I guess that gets back to the discussion in #2517. |
I don't think it matters much which code we map and which one we redirect for now, since #2517 should land soon(tm). |
To unify |
Ah right ... good catch! I think |
We could also make it a setting on the rule, rather than creating separate rules. But I don’t think we’ve articulated a strict philosophy either way there. |
use-contextlib-suppress (SIM105) is intentionally much weaker than try-except-pass (S110), and it’s not unreasonable to enable the former without the latter. See #1948. |
As per the rule naming convention established in #2712 the rule name should be the bad thing that's being checked for and not contain the solution, so we should merge the following rules accordingly:
S307
andPGH001
) #7283F509
andPLE1300
#11403In the long run it would be nice if ruff supported different autofixes for one violation, see #2713.
The text was updated successfully, but these errors were encountered: