How to write a test for query_string_parameters

[johansmitsnl]

I want to write a test for example: https://github.com/awslabs/aws-lambda-rust-runtime/blob/a9de2fcb24030a00e402348aba3c368b717feb6d/lambda-http/examples/hello-http-without-macros.rs#L15-L23

But until now it does not work.

#[cfg(test)]
mod tests {
    use super::*;
    use lambda_http::http::StatusCode;
    use lambda_http::{http, Body};

    #[tokio::test]
    async fn main_handles() {

        let request = http::Request::builder()
            .uri("https://api.com/?first_name=John")
            .expect("failed to build request");

        let expected = json!({"first_name": "John"}).into_response();
        let response = func(request, Context::default())
            .await
            .expect("expected Ok(_) value")
            .into_response();
        assert_eq!(response.body(), expected.body());
        assert_eq!(response.status(), StatusCode::OK)
    }
}

How can I stub the request?

[softprops]

You'll want to use with_query_string_parameters which should be accessible in a test config with you import lambda_http::RequestExt.

[mbrubeck]

with_query_string_parameters is not accessible from tests in downstream packages. It is marked #[cfg(test)] so it is included only when building the unit test binary for lambda_http itself. When building tests for downstream crates, lambda_http is built as a regular library, without --cfg test.

To expose this to downstream crates, it should be compiled unconditionally or behind a Cargo feature.

[softprops]

Good to know. If I don't get to it first, we'd be open to a pull request to add that feature flag.

The original intent was to get a small surface area and accomidate use cases that are test specific with a test cfg.

[johansmitsnl]

@softprops what would be the code to use it if that flag was enabled?
I run it from github master at the moment.

[softprops]

what would be the code to use it if that flag was enabled?

The target usage is unit tests in consumers crates

[johansmitsnl]

I'm relatively new to rust, would it be possible to alter my code above?

[johansmitsnl]

This works: #253 in my case. @paulvt helped me finding this change.

If changes are needed please let me know.

Now it is possible to use this:

        let mocked = hashmap! {
            "first_name".into() => vec!["John".into()]
        };
        let request = Request::default().with_query_string_parameters(mocked.clone());

        let expected = json!({"first_name": "John"}).into_response();
        let response = func(request, Context::default())
            .await
            .expect("expected Ok(_) value")
            .into_response();
        assert_eq!(response.body(), expected.body());
        assert_eq!(response.status(), StatusCode::OK)

[miere]

I believe this should be included on any further documentation describing how this "new lambda runtime" will work.

[schell]

Where does the hashmap! macro come from? This is the first time I've seen that used.

[paulvt]

@schell the maplit crate, see also: https://github.com/awslabs/aws-lambda-rust-runtime/blob/ae3ce1d4aee593b9425a045cd19d2b967d5cf367/lambda-http/src/lib.rs#L90

[johansmitsnl]

This is now solved in #253